Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes here, both making some functions tail-call recursive.
For
monotonePart
, the|>
prevented the optimization from happening.For
gatherWith
, it's the same issue but because of<|
. I made the same fix inelm-community/list-extra
(elm-community/list-extra@2d0eb64#diff-97b2cb39788ae3d6877530635d216e6cd361006507af40173e5affcb5f095331)I found this using using the [NoUnoptimizedRecursion](https://package.elm-lang.org/packages/jfmengels/elm-review-performance/latest/NoUnoptimizedRecursion]
elm-review
rule, which you can try out by running the following command:There are some more to be fixed, but they're not as trivial, and the performance benefits will have to be evaluated.
PS: Running the tests doesn't work. The
elm-explorations/test
dependency is missing, and I think some others too, but I am not sure which one.NoRedInk/elm-plot-rouge
?