Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @elastic/elasticsearch from 7.13.0 to 8.10.0 #1044

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 23, 2023

Bumps @elastic/elasticsearch from 7.13.0 to 8.10.0.

Release notes

Sourced from @​elastic/elasticsearch's releases.

v8.10.0

Changelog

v8.9.1

Changelog

v8.9.0

Changelog

v8.8.1

Changelog

v8.8.0

Changelog

v8.7.0

Changelog

v8.6.0

Changelog

v8.5.0

Changelog

v8.4.0

Changelog

v8.2.1

Changelog

v8.2.0

Changelog

v8.1.0

Changelog

v8.0.0

Changelog

v7.17.13

Changelog

v7.17.12

Changelog

v7.17.11

⚠️ NOTE: Due to a typing error in the version of 7.17.11 published to npm (see elastic/elasticsearch-js#1924), we recommend pinning your 7.x client version to 7.17.0 in your package.json. If you need fixes specific to 7.17.11, you can pin your package.json to version 7.17.11-patch.1 until 7.17.12 is published.

Changelog

... (truncated)

Changelog

Sourced from @​elastic/elasticsearch's changelog.

=== 8.10.0

[discrete] === Features

[discrete] ===== Support for Elasticsearch v8.10.0

You can find all the API changes https://www.elastic.co/guide/en/elasticsearch/reference/8.10/release-notes-8.10.0.html[here].

[discrete] === 8.9.1

[discrete] ==== Fixes

[discrete] ===== Upgrade Transport elastic/elasticsearch-js#1968

Upgrades @elastic/transport to the latest patch release to fix elastic/elastic-transport-js#69 bug] that could cause the process to exit when handling malformed HEAD requests.

[discrete] === 8.9.0

[discrete] ==== Features

[discrete] ===== Support for Elasticsearch v8.9.0

You can find all the API changes https://www.elastic.co/guide/en/elasticsearch/reference/8.9/release-notes-8.9.0.html[here].

[discrete] ===== Allow document to be overwritten in onDocument iteratee of bulk helper elastic/elasticsearch-js#1732

In the https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/client-helpers.html#bulk-helper[bulk helper], documents could not be modified before being sent to Elasticsearch. It is now possible to https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/client-helpers.html#_modifying_a_document_before_operation[modify a document] before sending it.

[discrete] ==== Fixes

[discrete] ===== Updated user-agent header elastic/elasticsearch-js#1954

The user-agent header the client used to connect to Elasticsearch was using a non-standard format that has been improved.

[discrete] === 8.8.1

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by joshmock, a new releaser for @​elastic/elasticsearch since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@elastic/elasticsearch](https://github.com/elastic/elasticsearch-js) from 7.13.0 to 8.10.0.
- [Release notes](https://github.com/elastic/elasticsearch-js/releases)
- [Changelog](https://github.com/elastic/elasticsearch-js/blob/main/docs/changelog.asciidoc)
- [Commits](elastic/elasticsearch-js@v7.13.0...v8.10.0)

---
updated-dependencies:
- dependency-name: "@elastic/elasticsearch"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 23, 2023
@sotojn
Copy link
Contributor

sotojn commented Oct 23, 2023

The changeling from version 7 to version 8 does have some stated breaking changes.

  • Drop old typescript definitions

Breaking: Yes | Migration effort: Medium
The current TypeScript definitions will be removed from the client, and the new definitions, which contain request and response definitions as well will be shipped by default.

  • Drop callback-style API

Breaking: Yes | Migration effort: Large
Maintaining both API styles is not a problem per se, but it makes error handling more convoluted due to async stack traces. Moving to a full-promise API will solve this issue.

There are more to list but after looking at the code I found that we never import and use it. It's a dependency inside of packages/terafoundation_elasticsearch_connector. I went as far as to pull it locally, ran yarn remove @elastic/elasticsearch, setup and rebuilt, and all the tests still passed.

In conclusion I think it's safe to bump but I could have a lack of understanding on why it's here. @godber

@sotojn sotojn requested a review from godber October 23, 2023 15:28
@godber
Copy link
Member

godber commented Oct 23, 2023

I don't think we can bump this one, though I don't have a good understanding of the details. My vague understanding here is that this connector enables teraslice to connect to a number of different versions/flavors of elasticsearch. At some point the clients started breaking compatibility with one another so our connector probes the search connector to see which version/flavor of elasticsearch something is, then creates a client object with the "best" client dependency.

I think roughly the mappings are:

  • @elastic/elasticsearch": "7.13.0" - ES 7
  • @opensearch-project/opensearch": "^1.1.0" - Opensearch 1
  • elasticsearch": "^15.4.1 - ES 6

You might dig around and see if you can find the code that does this selection when you have a chance. Some day, not today, it could be worth discussing this with @jsnoble. For now, lets ask dependabot to "ignore this major version". I am not sure if a minor version change is acceptable or not, THAT is worth asking Jared if it comes up.

@godber
Copy link
Member

godber commented Oct 23, 2023

@dependabot ignore this major version

@dependabot dependabot bot closed this Oct 23, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 23, 2023

OK, I won't notify you about version 8.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/elastic/elasticsearch-8.10.0 branch October 23, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants