Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR #456: Fix to version numbering so that it is in accordance with PE…
…P 404 Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged. Imported from GitHub PR #456 Recently I tried installing this repo through pip, and it failed with the following message: ``` raise InvalidVersion(f"Invalid version: '{version}'") pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: 'b4eb09b4a3d167557d999723f7c2ed0d53a1bb7d-' ``` After some googling, I found that this is by design: * pypa/setuptools#2497 * pypa/setuptools#3772 Apparently, `Setuptools` only supports version numbering in accordance with [PEP 404](https://peps.python.org/pep-0440/) from version 66 onwards. So I created a fork of this repo, changing the version numbering scheme so that it can be installed through pip. The idea is essentially the same as it is currently, with only some minor modifications. Currently, the version number is simply the hash of the most recent commit, so there isn't any pattern or sequence to be worried about. PEP 404 required the version number to be in base 10, so I changed the base 16 representation of the commit hash to base 10. By keeping the commit hash, the commit can still be retrieved through the version number. I also prepended the commit's timestamp, so that the more recent commits have higher version numbering. Copybara import of the project: - db7542d Change version numbering to be in accordance with PEP 440... by Eduardo <[email protected]> - 94860f6 Minor changes for clarity and add explanatory comments. by Eduardo <[email protected]> - f0d9155 Merge 94860f6 into b4eb0... by Eduardo Santos Carlos de Souza <[email protected]> PiperOrigin-RevId: 532326489
- Loading branch information