Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to apply QA API implementation feedback #202

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Mar 29, 2021

Description

Apply #173 feedbacks

This PR continues to work after #193

you can see updated swagger v2.2.1

closes: #XXXX

  • not clear
    • removed legacy, unofficial base_req, msg.proto #193
    • remove unofficial StdTx for Msg{*}Response
    • remove unofficial StdTx for Msg{*}Response
    • remove unused legacy PoolBatchResponse
  • documentation
    • clarify the role of pool_type_id
    • clarify the role of MsgStates

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #202 (222a5ae) into develop (63b6a90) will not change coverage.
The diff coverage is n/a.

❗ Current head 222a5ae differs from pull request most recent head a25929d. Consider uploading reports for the commit a25929d to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #202   +/-   ##
========================================
  Coverage    83.60%   83.60%           
========================================
  Files           20       20           
  Lines         2300     2300           
========================================
  Hits          1923     1923           
  Misses         203      203           
  Partials       174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6a90...a25929d. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review March 29, 2021 09:52
@dongsam dongsam merged commit 7c74deb into tendermint:develop Mar 29, 2021
@dongsam dongsam mentioned this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant