Handle maximum table name length #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
requested review from
ChuckHend,
ianstanton,
ryw,
sjmiller609 and
nhudson
as code owners
|
Nice! @vrmiguel can you add a test for a name > 58 (?) characters, and bump the version in core/Cargo.toml? |
v0idpwn
reviewed
Aug 10, 2023
| // https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS | ||
|
|
||
| // Default value of `NAMEDATALEN`, set in `src/include/pg_config_manual.h` | ||
| const NAMEDATALEN: usize = 64; |
There was a problem hiding this comment.
Is there an API where this configuration can be read, so you don't need to guess?
There was a problem hiding this comment.
This might be close, but need to look into this a bit more. Not sure how reliable it would be for our use case.
show max_identifier_length;
max_identifier_length
-----------------------
63
(1 row)There was a problem hiding this comment.
ChuckHend
approved these changes
Aug 14, 2023
* bump patch * Update Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for #33
This PR ensures tables are at most 59-characters long, since by default Postgres limits identifiers to 63 characters, and we add to it a 4-bytes long prefix. This is configurable, but would require building Postgres from source.
Docs: https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS