-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix timestamp mapped attribute cases #1593
Conversation
We should include tests about include also:
|
return; | ||
} | ||
} else { | ||
if (!typeInformation.timezone) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be precalculated to simplify logic and optimize. Minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4c8a624
jexlctxt[constants.TIMESTAMP_ATTRIBUTE] = timestamp.value; // nosense | ||
} else { | ||
timestamp.value = moment().tz(typeInformation.timezone).format('YYYY-MM-DD[T]HH:mm:ss.SSSZ'); | ||
jexlctxt[constants.TIMESTAMP_ATTRIBUTE] = timestamp.value; // nosense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jexlctxt is not used any more from this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#1557
This PR includes fixes and includes two new cases