Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Parse authSource variable into mongo url string #1527

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

cblanco-libelium
Copy link
Contributor

@cblanco-libelium cblanco-libelium commented Nov 13, 2023

Edit: issue #1526

- Overriding when user:pass is present in extraArgs
- Fix tests

I see that authSource had an independant ENV variable and treatment along the code, but the truth it's that authSource should concat in the string as an extraArgs. 
In my opinion the best way to allow backwards compatibility is to still parsing if comes in extraArgs, but overriding if the specific env variable is present. 
Also authSource should only used if user:pass are present so i included in the if statemente

    - Overriding when user:pass is present in extraArgs
    - Fix tests
@fgalan
Copy link
Member

fgalan commented Nov 14, 2023

Thank you for your contribution!

Please add an entry to the CHANGES_NEXT_RELEASE file (which is used to build the Changelog of next version) to describe the fix in the PR. Something like this:

- Fix: mongodb.authSource / IOTA_MONGO_AUTH_SOURCE was not correctly supported (#1526)

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 63d9bbd into telefonicaid:master Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants