-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) #1483
FIX: Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) #1483
Conversation
We should include at same point of the documentation (any suggestion @mapedraza ?) something like this:
or something with a similar meaning. |
Probably, instead of deleting, renaming them to |
Co-authored-by: Fermín Galán Márquez <[email protected]>
It depends on how strict we want to be with "illegal" measures. Deleting them will strongly disallow its use, while moving them to attributes In my opinion it's better to delete, but it's not a strong opinion. |
…sures Add tests for ID and Type colisions
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #1485
this should be tested