Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) #1483

Merged
merged 15 commits into from
Oct 3, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 2, 2023

Issue #1485

this should be tested

@AlvaroVega AlvaroVega changed the title remove measures with attributes name 'id' or 'type' [WIP] remove measures with attributes name 'id' or 'type' Oct 2, 2023
@fgalan
Copy link
Member

fgalan commented Oct 2, 2023

We should include at same point of the documentation (any suggestion @mapedraza ?) something like this:

Note that id and type are not valid attribute names at Context Broker. Thus, although a id or type will not break the IOT Agent, they are silently ignored and never progress toward Context Broker entities.

or something with a similar meaning.

@mapedraza
Copy link
Collaborator

mapedraza commented Oct 2, 2023

We should include at same point of the documentation (any suggestion @mapedraza ?) something like this:

Note that id and type are not valid attribute names at Context Broker. Thus, although a id or type will not break the IOT Agent, they are silently ignored and never progress toward Context Broker entities.

or something with a similar meaning.

Probably, instead of deleting, renaming them to _id or _type could be useful in the future. The note you propose sounds good

@fgalan
Copy link
Member

fgalan commented Oct 3, 2023

Probably, instead of deleting, renaming them to _id or _type could be useful in the future

It depends on how strict we want to be with "illegal" measures. Deleting them will strongly disallow its use, while moving them to attributes _id and _type will somehow allow its usage.

In my opinion it's better to delete, but it's not a strong opinion.

…sures

Add tests for ID and Type colisions
@AlvaroVega AlvaroVega changed the title [WIP] remove measures with attributes name 'id' or 'type' Remove measures with attributes name 'id' or 'type' Oct 3, 2023
@AlvaroVega AlvaroVega marked this pull request as ready for review October 3, 2023 07:14
@mapedraza
Copy link
Collaborator

LGTM

@AlvaroVega AlvaroVega changed the title Remove measures with attributes name 'id' or 'type' Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) Oct 3, 2023
@AlvaroVega AlvaroVega changed the title Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) FIX: Remove measures with attributes name 'id' or 'type' (hotfix 3.4.3) Oct 3, 2023
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
doc/api.md Outdated Show resolved Hide resolved
doc/api.md Outdated Show resolved Hide resolved
doc/api.md Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit d48e188 into release/3.4.0 Oct 3, 2023
@fgalan fgalan deleted the fix/remove_measures_with_attribute_name_id_type branch October 3, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants