NGSIv1 regs isDomain/metadta removal and render() to toJsonv1() renaming #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @fisuda There are some changes in .md files in this PR that I think would need to be synced in the Japanese translation. |
|
Noted with thanks. |
kzangeli
reviewed
Oct 1, 2018
src/lib/ngsi/ContextAttribute.cpp
Outdated
| */ | ||
| std::string ContextAttribute::renderAsJsonObject | ||
| std::string ContextAttribute::toJsonV1AsJsonObject |
There was a problem hiding this comment.
As json is now part of the prefix, it could be dropped in the end of the name:
toJsonV1AsObject
Just a suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with #1298 and includes two pieces of work:
I'd recommend to review commit per commit. Only the first two ones are interesing, the others are rutinary adjustment in ftest and utest.