Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Errors For .nodes #2

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Mar 27, 2024

When calling .nodes <file> there were a few unnecessary error cases:

  1. If there were no TSP-Link nodes to initialize, an error would be added to the errorqueue
    • This was fixed by using tsplink.reset(1) and tsplink.initialize(0) instead of the no-parameter overloads
  2. If the given file didn't exist, an error was thrown even though we can create it.
    • This was fixed by removing the check for file existence.

This PR also includes an incidental fix for a clippy warning. We were calling enumerate unnecessarily.

@esarver esarver self-assigned this Mar 27, 2024
@esarver esarver requested a review from a team as a code owner March 27, 2024 20:14
Copy link

github-actions bot commented Mar 27, 2024

Code Coverage

Package Line Rate Health
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
instrument-repl/src/resources/mod.rs 100%
instrument-repl/src/instrument.rs 86%
kic-discover/src/usbtmc/mod.rs 0%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
instrument-repl/src/error.rs 0%
kic-discover/src/main.rs 0%
instrument-repl/src/repl.rs 0%
kic/src/error.rs 0%
Summary 17% (295 / 1783)

@jharajeev55 jharajeev55 added the enhancement New feature or request label Mar 28, 2024
@esarver esarver requested a review from jharajeev55 April 1, 2024 19:20
@esarver esarver merged commit 28ea880 into main Apr 2, 2024
10 checks passed
@esarver esarver deleted the improvement/TSP-553-eliminate-errors-on-nodes branch April 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants