-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and add missing dependencies #19
Conversation
Also, fixed the link to the ReadtheDocs page and license badge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 77.61% 77.61%
=======================================
Files 3 3
Lines 487 487
Branches 106 106
=======================================
Hits 378 378
Misses 89 89
Partials 20 20 ☔ View full report in Codecov by Sentry. |
Test Results (macos)
|
Test Results (ubuntu)
|
Test Results (windows)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But still package on PyPi is TekHSI. This has to be also updated in package build workflow.
Can you put your comment into a file? I don't know where it belongs. The package names on PyPI are case insensitive and also underscores/dashes are interchangeable. |
Proposed changes
This adds missing dependencies and updates links in the documentation.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>