Add a flag on controllers to configure resyncPeriod #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
vdemeester
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
vdemeester
force-pushed
the
3676-configure-resync-period
branch
2 times, most recently
from
172f945
to
7c78805
Compare
tekton-robot
added
size/M
vdemeester
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
vdemeester
force-pushed
the
3676-configure-resync-period
branch
from
7c78805
to
eb3842a
Compare
|
/approve |
tekton-robot
added
the
approved
This should allow advanced user/cluster-admin to configure the resyncPeriod to a value that fit their cluster instead of relying on the default 10h one. This is related to tektoncd#3676. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
commented
Jun 18, 2024
| @@ -0,0 +1,82 @@ | |||
| <!-- | |||
| --- | |||
| linkTitle: "Tekton Controllers flags" | |||
There was a problem hiding this comment.
@tektoncd/core-maintainers Is that enough for documentation ? 🤔
vdemeester
force-pushed
the
3676-configure-resync-period
branch
from
eb3842a
to
187f3e0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should allow advanced user/cluster-admin to configure the
resyncPeriod to a value that fit their cluster instead of relying on
the default 10h one.
This is related to #3676.
Signed-off-by: Vincent Demeester [email protected]
/kind feature
/wip
Probably needs some doc updates, will do if this approach seems ok.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes