Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update GetNameAndNamespace Parameters #7984

Merged
merged 1 commit into from
May 27, 2024

Conversation

Aleromerog
Copy link
Contributor

@Aleromerog Aleromerog commented May 24, 2024

Changes

Fix for issue #7980 Pipelines ignoring following name fields on resolvers

Fixes: #7980

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2024
@Aleromerog
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2024
@Aleromerog
Copy link
Contributor Author

/assign @chitrangpatel

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 81.5% -1.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 81.5% -1.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 80.8% -1.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 80.8% -1.8

@chitrangpatel chitrangpatel changed the title Update GetNameAndNamespace Parameters Fix: Update GetNameAndNamespace Parameters May 24, 2024
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Aleromerog 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@chitrangpatel
Copy link
Contributor

/cherry-pick release-v0.60.x

@tekton-robot
Copy link
Collaborator

@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-v0.60.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.60.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleromerog this generally LGTM just a few comments.

pkg/resolution/resource/name.go Show resolved Hide resolved
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 88.5% 5.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/remote/resolution/resolver.go 88.0% 88.5% 0.5
pkg/remoteresolution/remote/resolution/resolver.go 82.6% 88.5% 5.9

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aleromerog

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, JeromeJu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,chitrangpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JeromeJu
Copy link
Member

cc @tektoncd/core-maintainers @tektoncd/core-collaborators PTAL

@chitrangpatel
Copy link
Contributor

Thanks for the fix! This was the intended behavior and was an oversight on my end.
Using maintainer discretion here to get this bug fix in quickly. It's a minor change that does not change anything as far as the feature goes.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@tekton-robot tekton-robot merged commit ca93bc6 into tektoncd:main May 27, 2024
12 of 13 checks passed
@tekton-robot
Copy link
Collaborator

@chitrangpatel: new pull request created: #7994

In response to this:

/cherry-pick release-v0.60.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines ignoring following name fields on resolvers
4 participants