Using image with "full" reference in tests

This moves any "implicit" references (such as `busybox` or `ubuntu`) to full references instead (`docker.io/library/busybox`, …). This is related to #4551. This would help us identify all images using `docker.io` used in tests and thus migrate from them in the future. Signed-off-by: Vincent Demeester <[email protected]>
tektoncd · Jul 2, 2024 · f8b1799 · f8b1799
1 parent 009c171
commit f8b1799
Show file tree

Hide file tree

Showing 157 changed files with 539 additions and 539 deletions.
diff --git a/examples/v1/pipelineruns/4808-regression.yaml b/examples/v1/pipelineruns/4808-regression.yaml
@@ -11,7 +11,7 @@ spec:
       type: string
   steps:
     - name: print-result
-      image: bash:latest
+      image: docker.io/library/bash:latest
       env:
         - name: PARAM_TO_PRINT
           value: $(params.TO_PRINT)
@@ -39,7 +39,7 @@ spec:
       description: A result string
   steps:
     - name: gen-result
-      image: bash:latest
+      image: docker.io/library/bash:latest
       env:
         - name: PARAM_STRING_LENGTH
           value: $(params.STRING_LENGTH)

diff --git a/examples/v1/pipelineruns/6139-regression.yaml b/examples/v1/pipelineruns/6139-regression.yaml
@@ -15,7 +15,7 @@ spec:
           results:
             - name: result-one
           steps:
-          - image: alpine
+          - image: docker.io/library/alpine
             script: |
               #!/bin/sh
               echo "Hello world!"
@@ -28,7 +28,7 @@ spec:
           results:
             - name: result-two
           steps:
-          - image: alpine
+          - image: docker.io/library/alpine
             script: |
               #!/bin/sh
               echo "Goodbye world!"
@@ -43,7 +43,7 @@ spec:
           results:
             - name: result-three
           steps:
-          - image: alpine
+          - image: docker.io/library/alpine
             script: |
               #!/bin/sh
               echo "Shutdown world!"

diff --git a/examples/v1/pipelineruns/alpha/ignore-task-error.yaml b/examples/v1/pipelineruns/alpha/ignore-task-error.yaml
@@ -10,7 +10,7 @@ spec:
         taskSpec:
           steps:
             - name: write
-              image: alpine
+              image: docker.io/library/alpine
               script: |
                 echo "this is a failing task"
                 exit 1
@@ -20,6 +20,6 @@ spec:
         taskSpec:
           steps:
             - name: write
-              image: alpine
+              image: docker.io/library/alpine
               script: |
                 echo "this is a success task"
diff --git a/examples/v1/pipelineruns/alpha/param-enum.yaml b/examples/v1/pipelineruns/alpha/param-enum.yaml
@@ -9,7 +9,7 @@ spec:
     enum: ["v1", "v2", "v3"]
   steps:
   - name: build
-    image: bash:latest
+    image: docker.io/library/bash:latest
     script: |
       echo "$(params.message)"
 ---

diff --git a/examples/v1/pipelineruns/alpha/pipelinerun-large-results.yaml b/examples/v1/pipelineruns/alpha/pipelinerun-large-results.yaml
@@ -20,7 +20,7 @@ spec:
           type: string
   steps:
     - name: step1
-      image: alpine
+      image: docker.io/library/alpine
       script: |
         # produce a result - a random string with 2,500 characters - result1
         tr -dc A-Za-z0-9 </dev/urandom | head -c 2500 | tee $(results.result1.path);
@@ -63,7 +63,7 @@ spec:
           type: string
   steps:
     - name: step1
-      image: alpine
+      image: docker.io/library/alpine
       args: [
         "$(params.param3[*])"
       ]

diff --git a/examples/v1/pipelineruns/alpha/pipelinerun-with-cel-when-expressions.yaml b/examples/v1/pipelineruns/alpha/pipelinerun-with-cel-when-expressions.yaml
@@ -25,7 +25,7 @@ spec:
               description: The workspace to create the readme file in
           steps:
             - name: write-new-stuff
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: 'touch $(workspaces.source.path)/README.md'
       - name: check-file
         params:
@@ -47,7 +47,7 @@ spec:
               description: indicates whether the file exists or is missing
           steps:
             - name: check-file
-              image: alpine
+              image: docker.io/library/alpine
               script: |
                 if test -f $(workspaces.source.path)/$(params.path); then
                   printf yes | tee $(results.exists.path)
@@ -60,23 +60,23 @@ spec:
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: 'echo file exists'
       - name: task-should-be-skipped-1
         when:
           - cel: "'$(tasks.check-file.results.exists)'=='missing'" # when expression using task result, evaluates to false
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: task-should-be-skipped-2  # when expression using parameter, evaluates to false
         when:
           - cel: "'$(params.path)'!='README.md'"
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: task-should-be-skipped-3  # task with when expression and run after
         runAfter:
@@ -86,7 +86,7 @@ spec:
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
     finally:
       - name: finally-task-should-be-skipped-1  # when expression using execution status, evaluates to false
@@ -95,39 +95,39 @@ spec:
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: finally-task-should-be-skipped-2  # when expression using task result, evaluates to false
         when:
           - cel: "'$(tasks.check-file.results.exists)'=='missing'"
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: finally-task-should-be-skipped-3  # when expression using parameter, evaluates to false
         when:
           - cel: "'$(params.path)'!='README.md'"
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: finally-task-should-be-skipped-4  # when expression using tasks execution status, evaluates to false
         when:
           - cel: "'$(tasks.status)'=='Failure'"
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: finally-task-should-be-skipped-5  # when expression using tasks execution status, evaluates to false
         when:
           - cel: "'$(tasks.status)'=='Succeeded'"
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: exit 1
       - name: finally-task-should-be-executed  # when expression using execution status, tasks execution status, param, and results
         when:
@@ -138,7 +138,7 @@ spec:
         taskSpec:
           steps:
             - name: echo
-              image: ubuntu
+              image: docker.io/library/ubuntu
               script: 'echo finally done'
   params:
     - name: path

diff --git a/examples/v1/pipelineruns/alpha/stepaction-params.yaml b/examples/v1/pipelineruns/alpha/stepaction-params.yaml
@@ -25,7 +25,7 @@ spec:
         key1: "step-action default key1"
         key2: "step-action default key2"
         key3: "step-action default key3"
-  image: bash:3.2
+  image: docker.io/library/bash:3.2
   args: [
     "echo",
     "$(params.array-param[*])",

diff --git a/examples/v1/pipelineruns/beta/7392-regression.yaml b/examples/v1/pipelineruns/beta/7392-regression.yaml
@@ -10,7 +10,7 @@ spec:
     default: []
   steps:
   - name: step1
-    image: bash:latest
+    image: docker.io/library/bash:latest
     args:
       - --images
       - $(params.arrayVal1[*])
@@ -20,7 +20,7 @@ spec:
         echo $arg
       done
   - name: step2
-    image: bash:latest
+    image: docker.io/library/bash:latest
     script: |
       #!/usr/bin/env bash
       echo -n '[]' | tee $(results.resultArray.path)

diff --git a/examples/v1/pipelineruns/beta/isolated-workspaces.yaml b/examples/v1/pipelineruns/beta/isolated-workspaces.yaml
@@ -37,7 +37,7 @@ spec:
         workspaces:
         - name: creds
         steps:
-        - image: alpine:3.12.0
+        - image: docker.io/library/alpine:3.12.0
           script: |
             if [ ! -d /creds ] ; then
               echo "unable to access creds"
@@ -46,7 +46,7 @@ spec:
           workspaces:
           - name: creds
             mountpath: /creds
-        - image: alpine:3.12.0
+        - image: docker.io/library/alpine:3.12.0
           script: |
             if [ -d /workspace/creds ] ; then
               echo "this step should not be able to see creds"

diff --git a/examples/v1/pipelineruns/beta/pipeline-emitting-results.yaml b/examples/v1/pipelineruns/beta/pipeline-emitting-results.yaml
@@ -13,7 +13,7 @@ spec:
               description: The array results
           steps:
             - name: write-array
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 echo -n "[\"1\",\"2\",\"3\"]" | tee $(results.array-results.path)
@@ -32,7 +32,7 @@ spec:
                 }
           steps:
             - name: write-array
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 echo -n "{\"foo\":\"bar\",\"hello\":\"world\"}" | tee $(results.object-results.path)

diff --git a/examples/v1/pipelineruns/beta/pipeline-with-when-expressions-using-array-results.yaml b/examples/v1/pipelineruns/beta/pipeline-with-when-expressions-using-array-results.yaml
@@ -18,7 +18,7 @@ spec:
               description: The array results
           steps:
             - name: write-array
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 image1="abc.dev/notsofamousimage/image"
@@ -34,7 +34,7 @@ spec:
         taskSpec:
           steps:
             - name: say-hi
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 echo "hi"
       - name: task3
@@ -50,7 +50,7 @@ spec:
         taskSpec:
           steps:
             - name: say-hello
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 echo "hello"
       - name: task4
@@ -62,7 +62,7 @@ spec:
         taskSpec:
           steps:
             - name: say-hi
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 echo "hi"
       - name: task5
@@ -74,15 +74,15 @@ spec:
         taskSpec:
           steps:
             - name: do-not-execute
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 exit 1
     finally:
       - name: validate-tasks
         taskSpec:
           steps:
             - name: validate-tasks-section
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 if [[ $(context.task2.status) != "Succeeded" ]]; then
                   echo "task2 should have been succeeded but instead has status - $(context.task2.status)"

diff --git a/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-and-results.yaml b/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-and-results.yaml
@@ -12,7 +12,7 @@ spec:
     - name: url
   steps:
     - name: echo
-      image: alpine
+      image: docker.io/library/alpine
       script: |
         echo "Visit $(params.url) on $(params.platform) using $(params.browser)."
 ---
@@ -32,7 +32,7 @@ spec:
               type: array
           steps:
             - name: produce-a-list-of-platforms
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 echo -n "[\"linux\",\"mac\",\"windows\"]" | tee $(results.platforms.path)
@@ -44,12 +44,12 @@ spec:
             - name: url
           steps:
             - name: produce-a-list-of-browsers
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 echo -n "[\"chrome\",\"safari\",\"firefox\"]" | tee $(results.browsers.path)
             - name: produce-url
-              image: bash:latest
+              image: docker.io/library/bash:latest
               script: |
                 #!/usr/bin/env bash
                 echo -n "myfavoritesitedotcom" | tee $(results.url.path)

diff --git a/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-array-references.yaml b/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-array-references.yaml
@@ -13,7 +13,7 @@ spec:
       default: ""
   steps:
     - name: echo
-      image: alpine
+      image: docker.io/library/alpine
       script: |
         echo "$(params.platform) and $(params.browser)"
 ---

diff --git a/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-context-variables.yaml b/examples/v1/pipelineruns/beta/pipelinerun-with-matrix-context-variables.yaml
@@ -8,7 +8,7 @@ spec:
       type: string
   steps:
     - name: validate
-      image: alpine
+      image: docker.io/library/alpine
       args: ["$(params.matrixlength)"]
       script: |
         #!/usr/bin/env sh
@@ -32,7 +32,7 @@ spec:
       type: string
   steps:
     - name: validate
-      image: alpine
+      image: docker.io/library/alpine
       script: |
         #!/usr/bin/env sh
         echo "Validating the length of the matrix results context variable"
@@ -61,7 +61,7 @@ spec:
     - name: IMAGE-URL
   steps:
     - name: produce-results
-      image: bash:latest
+      image: docker.io/library/bash:latest
       script: |
         #!/usr/bin/env bash
         echo "Building image for $(params.IMAGE)"