Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant six dependency and upgrade syntax for Python 3 #73

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 20, 2024

This library no longer supports Python 2 but is still using and installing the six compat library as a dependency.

Let's remove it and use the standard library directly instead.

@tedder
Copy link
Owner

tedder commented Jul 21, 2024

@hugovk can you rebase? I just committed code to fix the failing unit test.

Also curious if you have a reason for the wheel removal.

@hugovk
Copy link
Contributor Author

hugovk commented Jul 21, 2024

@hugovk can you rebase? I just committed code to fix the failing unit test.

Done!

Also curious if you have a reason for the wheel removal.

Do you mean b8306c9 ?

It's not removing a wheel, but telling it not to create a "universal" wheel. Universal wheels are for when you want to support both Python 2 and Python 3, and are no longer needed for Python 3 only:

https://packaging.python.org/en/latest/guides/dropping-older-python-versions/#dealing-with-the-universal-wheels

@tedder
Copy link
Owner

tedder commented Jul 21, 2024

It's not removing a wheel, but telling it not to create a "universal" wheel. Universal wheels are for when you want to support both Python 2 and Python 3, and are no longer needed for Python 3 only:

Perfect. I just didn't follow that.

@tedder tedder merged commit 67e395f into tedder:main Jul 21, 2024
6 checks passed
@hugovk hugovk deleted the rm-six branch July 21, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants