Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve performance #4

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Feature/improve performance #4

merged 6 commits into from
Oct 10, 2023

Conversation

Kylewalow
Copy link
Contributor

Pull request

Creators Checklist

Thanks for your Contribution 🎉

Before you request a review, please check the following:

  • If you worked on a Jira Task: did you move the task to the review state?
  • If you worked on a Jira Task: did you name the PR containing the task ID?
  • Did you fullfill the business case? (Check the Jira task again to be sure).
  • Did you cleanup your codebase (remove unused and commented code, remove dumps, ray usages and console logs)?
  • If needed: did you write any tests and do they pass?
  • Did you push the latest changes?
  • Did you check for merge conflicts?

Reviewers Checklist

This list should help you to review your pull request:

  • Did you check the code is readable and maintainable (complexity!)?
  • Did you check code and comments for typos?
  • If possible: did you check the code matches the requested business case?
  • Did all tests pass?
  • For big PRs: Did you smoke test it in your local test environment?

After the PR is merged:

  • Did you delete the PR branch?
  • Did you mark the Jira task as done?
  • Was the deployment successful?

Copy link
Contributor

@buffalom buffalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenni ds richtig verstah, gits ke Problem, wemer ShouldBeUniqueUntilProcessing und WithoutOverlapping itz scho kombinierä. Wird eifach, we ds Issue laravel/framework#48013 resolved isch, no performanter.

src/Jobs/UpdateMissingAltCacheJob.php Outdated Show resolved Hide resolved
@Kylewalow Kylewalow merged commit b2a8099 into main Oct 10, 2023
@Kylewalow Kylewalow deleted the feature/improve-performance branch October 10, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants