Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set cookie when jwt is set in header #929

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

lfleischmann
Copy link
Member

Description

Set session/JWT cookie only when Session.enable_auth_token_header is set to false.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 21, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@lfleischmann lfleischmann requested review from FreddyDevelop, like-a-bause and bjoern-m and removed request for FreddyDevelop and like-a-bause July 21, 2023 11:41
Copy link
Contributor

@FreddyDevelop FreddyDevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfleischmann lfleischmann merged commit 7ae10a4 into main Jul 26, 2023
11 checks passed
@lfleischmann lfleischmann deleted the fix-dont-set-cookie-when-jwt-is-set-in-header branch July 26, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants