fix MFA login with security key #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MFA login with security key due to wrongly used validation method of the webauthn library. The security key validation must not use the validation method for discoverable credentials, because the MFA credential is not created as a discoverable credential. Because of the usage of the wrong method a MFA login with a security key never succeeds.
FreddyDevelop
changed the title
lfleischmann
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MFA login with security key due to wrongly used validation method of the webauthn library. The security key validation must not use the validation method for discoverable credentials, because the MFA credential is not created as a discoverable credential. Because of the usage of the wrong method a MFA login with a security key never succeeds.
Implementation
Use the correct webauthn validation method to validate the MFA security key response.
Tests