Merge pull request DSpace#3067 from Neki-IT/BrowseByAuthorSeriousIssues

Fix "Browse by Author" remaining serious accessibility issues
tdonohue · Jun 14, 2024 · bf5e9b9 · bf5e9b9
2 parents 4e93255 + ff68eac
commit bf5e9b9
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/src/app/shared/starts-with/text/starts-with-text.component.html b/src/app/shared/starts-with/text/starts-with-text.component.html
@@ -1,10 +1,13 @@
 <form class="w-100" [formGroup]="formData" (ngSubmit)="submitForm(formData.value)">
+<div class="mb-3">
   <div class="row">
-    <div class="form-group input-group col-8 col-sm-12 col-md-6">
-      <input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.startsWith.type_text' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
+    <div class="form-group input-group col-sm-12 col-md-6 col-auto">
+      <input class="form-control" [attr.aria-label]="'browse.startsWith.input' | translate" placeholder="{{'browse.search-form.placeholder' | translate}}" type="text" name="startsWith" formControlName="startsWith" [value]="getStartsWith()" />
       <span class="input-group-append">
         <button class="btn btn-primary" type="submit"><i class="fas fa-book-open"></i> {{'browse.startsWith.submit' | translate}}</button>
       </span>
     </div>
   </div>
+  <small class="text-muted">{{'browse.startsWith.type_text' | translate}}</small>
+</div>
 </form>
diff --git a/src/app/shared/starts-with/text/starts-with-text.component.scss b/src/app/shared/starts-with/text/starts-with-text.component.scss
@@ -3,3 +3,7 @@
   background-color: var(--bs-input-bg);
   color: var(--bs-input-color);
 }
+
+.form-group {
+  margin-bottom: 0;
+}
diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5
@@ -6737,4 +6737,6 @@
   "item.page.cc.license.title": "Creative Commons license",
 
   "item.page.cc.license.disclaimer": "Except where otherwised noted, this item's license is described as",
+
+  "browse.search-form.placeholder": "Search the repository",
 }
diff --git a/src/assets/i18n/es.json5 b/src/assets/i18n/es.json5
@@ -8254,6 +8254,8 @@
   // "access-control-option-end-date-note": "Select the date until which the related access condition is applied",
   "access-control-option-end-date-note": "Escoja la fecha hasta la cuál se aplicarán las condiciones de acceso especificadas",
 
+  //"browse.search-form.placeholder": "Search the repository",
+  "browse.search-form.placeholder": "Buscar en el repositorio",
 
 
 }
diff --git a/src/assets/i18n/pt-BR.json5 b/src/assets/i18n/pt-BR.json5
@@ -1693,7 +1693,7 @@
   "browse.startsWith.type_date.label": "Ou digite na data (year-month) e clique no botão de Ir",
 
   // "browse.startsWith.type_text": "Filter results by typing the first few letters",
-  "browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras:",
+  "browse.startsWith.type_text": "Filtrar resultados informando as primeiras letras",
 
   // "browse.startsWith.input": "Filter", (Auto-Translated)
   "browse.startsWith.input": "Filtro",
@@ -8274,4 +8274,7 @@
 
   // "access-control-option-end-date-note": "Select the date until which the related access condition is applied", (Auto-Translated)
   "access-control-option-end-date-note": "Selecione a data até a qual a condição de acesso relacionada é aplicada",
+
+  //"browse.search-form.placeholder": "Search the repository",
+  "browse.search-form.placeholder": "Buscar no repositório",
 }