Merge pull request DSpace#3097 from tdonohue/port_3061_to_main

[Port main] Hide search text field when number of facet values is less than the maximum
tdonohue · May 31, 2024 · b0a8a50 · b0a8a50
2 parents b9a1045 + bb341a3
commit b0a8a50
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/...arch-filters/search-filter/search-authority-filter/search-authority-filter.component.html b/...arch-filters/search-filter/search-authority-filter/search-authority-filter.component.html
@@ -26,5 +26,6 @@
                           (submitSuggestion)="onSubmit($event)"
                           (clickSuggestion)="onClick($event)"
                           (findSuggestions)="findSuggestions($event)"
+                          *ngIf="(isAvailableForShowSearchText | async) === false"
                           ngDefaultControl></ds-filter-input-suggestions>
 </div>
diff --git a/.../search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.ts b/.../search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.ts
@@ -104,6 +104,10 @@ export class SearchFacetFilterComponent implements OnInit, OnDestroy {
    */
   isLastPage$: BehaviorSubject<boolean> = new BehaviorSubject(false);
 
+  /**
+   * Emits true if show the search text
+   */
+  isAvailableForShowSearchText: BehaviorSubject<boolean> = new BehaviorSubject(false);
   /**
    * The value of the input field that is used to query for possible values for this filter
    */
@@ -289,6 +293,8 @@ export class SearchFacetFilterComponent implements OnInit, OnDestroy {
         getFirstSucceededRemoteDataPayload(),
         tap((facetValues: FacetValues) => {
           this.isLastPage$.next(hasNoValue(facetValues?.next));
+          const hasLimitFacets =  facetValues?.page?.length < facetValues?.facetLimit;
+          this.isAvailableForShowSearchText.next(hasLimitFacets && hasNoValue(facetValues?.next));
         }),
       )),
       map((newFacetValues: FacetValues) => {

diff --git a/...arch-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.html b/...arch-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.html
@@ -26,6 +26,7 @@
                           (submitSuggestion)="onSubmit($event)"
                           (clickSuggestion)="onClick($event)"
                           (findSuggestions)="findSuggestions($event)"
+                          *ngIf="(isAvailableForShowSearchText | async) === false"
                           ngDefaultControl
     ></ds-filter-input-suggestions>
 </div>

diff --git a/.../search/search-filters/search-filter/search-text-filter/search-text-filter.component.html b/.../search/search-filters/search-filter/search-text-filter/search-text-filter.component.html
@@ -26,5 +26,6 @@
                           (submitSuggestion)="onSubmit($event)"
                           (clickSuggestion)="onClick($event)"
                           (findSuggestions)="findSuggestions($event)"
+                          *ngIf="(isAvailableForShowSearchText | async) === false"
                           ngDefaultControl></ds-filter-input-suggestions>
 </div>