Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True single namespace functionality #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GoodOldJack12
Copy link
Contributor

Updates the API version like #60

This change makes it possible to deploy consul-register in a single namespace without needing cluster-wide permissions.
rolebinding.yaml contains the minimal permission set required for this setup. (watch doesn't seem to break all functionality, but the application does produce errors if its not present)

I'm not familiar with Go, so please check if I didn't accidentally break something.

@shivamnarula
Copy link

Why do we need this when we can use ClusterRoleBinding and that works?

@GoodOldJack12
Copy link
Contributor Author

Why do we need this when we can use ClusterRoleBinding and that works?

Because then it wouldn't be truly in a single name space. A good use case for this is multi-tenant setups where a tenant might not have cluster wise permissions.

Really, there's no reason to have a cluster role for this functionality.

This would also make this application have an advantage over the official consul solution, which can't be installed in a single namespace

@shivamnarula
Copy link

Why do we need this when we can use ClusterRoleBinding and that works?

Because then it wouldn't be truly in a single name space. A good use case for this is multi-tenant setups where a tenant might not have cluster wise permissions.

Really, there's no reason to have a cluster role for this functionality.

This would also make this application have an advantage over the official consul solution, which can't be installed in a single namespace

Understood. Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants