Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADDED] Added validation for module. #443

Closed
wants to merge 18 commits into from
Closed

[ADDED] Added validation for module. #443

wants to merge 18 commits into from

Conversation

deepti-50
Copy link
Contributor

Description

used middleware validate service for validating ids in controller/module.js file

Fixes

Fixes #426

Checklist

  • [ x] Code follows project's style guidelines.
  • [x ] Changes are documented appropriately.

(PS → Make Sure Pull request title is meaningful.)

callistox9 and others added 18 commits October 22, 2023 10:53
@callistox9
minor_typo corrected
19550ef
@TejasNair9977
Merge pull request #416 from callistox9/typo_readme
8b362d7 
minor_typo corrected
@TejasNair9977
added mock data for accred, org, infra, department, topics, modules, …
7537299 
…major fixes
@Gauravpadam
docker compose added for handling replicaSets
0628964
@TejasNair9977 @Gauravpadam
fixed dockerfile
b60d7c2 
Co-authored-by: Gaurav Padam <[email protected]>
@TejasNair9977
used mongo instead of bitnami
7c49e5a
@TejasNair9977
added .env back to dockerignore
4c412ed
@TejasNair9977
Merge pull request #417 from Gauravpadam/20232610_docker_compose_for_…
5118489 
…replicaSets

Docker compose for handling Mongo replicaSets
@TejasNair9977
added faker for courses and everything under
cac9c58
@TejasNair9977
completed course additions for placeholder data
9fb5d9e
@kskarthik5
Merge pull request #418 from tcet-opensource/414-filldbwithplaceholde…
186eb66 
…rdata

Filled DB with placeholder data
Initialize-all-the-test-data-in-setup.js-using-spawn
1c4b14d
Fixed the error while closing the child process
57e05c8
@Shubhangam333
feat: added validation to exam controller
0f63d5b
@TejasNair9977
Merge pull request #437 from tcet-opensource/feat-436-Initialize-all-…
ff1d374 
…test-data-in-setup.js

Feat: Initialize all test data in setup.js
@TejasNair9977
made middleware more portable and usable
80e0d14
@TejasNair9977
Merge pull request #438 from Shubhangam333/devteam
795addf 
[FEATURE]: [Added Validation for Exam]
@TejasNair9977
Rename EntityIdValidation.js to entityIdValidation.js
0b2046e 
hotpatch
@deepti-50 deepti-50 closed this Nov 3, 2023
@deepti-50 deepti-50 deleted the 426-add-validation-for-module branch November 3, 2023 16:14
@deepti-50 deepti-50 restored the 426-add-validation-for-module branch November 3, 2023 16:22
@deepti-50 deepti-50 reopened this Nov 3, 2023
@sumitst05
Copy link
Contributor

Please do not open a PR on main 🙏🏻

@TejasNair9977
Copy link
Member

uhhh you didnt add any commits??

@deepti-50
Copy link
Contributor Author

uhhh you didnt add any commits??

I did

@TejasNair9977
Copy link
Member

if you did, its not pushed, please have a look at the commit list here

@TejasNair9977
Copy link
Member

your commit is not here

@TejasNair9977
Copy link
Member

image
further proof just so its clear

@deepti-50
Copy link
Contributor Author

image further proof just so its clear

let me commit again...will this be okay?

@TejasNair9977
Copy link
Member

sure, please go ahead

@TejasNair9977
Copy link
Member

duplicate

@TejasNair9977 TejasNair9977 added the duplicate This issue or pull request already exists label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejasNair9977 TejasNair9977 Awaiting requested review from TejasNair9977

Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat]: [Add Validation for Module]
7 participants
@deepti-50 @sumitst05 @TejasNair9977 @callistox9 @Gauravpadam @kskarthik5 @Shubhangam333