-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
213 Create paper model #223
Conversation
Hey @ANKIT638-ux , this looks good but can you use a string instead of using mongoose long for answerSheetId? Sorry for the change in plans. Please reset the files other than the model file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Long with String.
Should I remove mongoose-long from package.json as well or do you want me to keep it |
…backend into 213_Create_model_paper
Ahh, @ANKIT638-ux I'm sorry for the late reply, but since mongoose-long isnt being used, please remove that package as well, let the model be the only change in your PR. Also, please ping me like @TejasNair9977 so I can get a notification for this! |
…backend into 213_Create_model_paper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Created paper model and added a mongoose-long package for storing long int values .
Fixes
Fixes #213
Checklist
Notes
Check the mongoose-long package.
(PS → Make Sure Pull request title is meaningful.)