Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

213 Create paper model #223

Merged
merged 6 commits into from
Aug 26, 2023
Merged

213 Create paper model #223

merged 6 commits into from
Aug 26, 2023

Conversation

ANKIT638-ux
Copy link
Contributor

Description

Created paper model and added a mongoose-long package for storing long int values .

Fixes

Fixes #213

Checklist

  • Code follows project's style guidelines.
  • Changes are documented appropriately.

Notes

Check the mongoose-long package.

(PS → Make Sure Pull request title is meaningful.)

@TejasNair9977
Copy link
Member

Hey @ANKIT638-ux , this looks good but can you use a string instead of using mongoose long for answerSheetId? Sorry for the change in plans. Please reset the files other than the model file.

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Long with String.

@ANKIT638-ux
Copy link
Contributor Author

Should I remove mongoose-long from package.json as well or do you want me to keep it

@TejasNair9977
Copy link
Member

TejasNair9977 commented Aug 23, 2023

Ahh, @ANKIT638-ux I'm sorry for the late reply, but since mongoose-long isnt being used, please remove that package as well, let the model be the only change in your PR. Also, please ping me like @TejasNair9977 so I can get a notification for this!

Copy link
Contributor

@kskarthik5 kskarthik5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kskarthik5 kskarthik5 merged commit 036be69 into development Aug 26, 2023
1 check passed
@TejasNair9977 TejasNair9977 deleted the 213_Create_model_paper branch October 15, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants