Update attendance.js

tcet-opensource · Dec 19, 2023 · 4b7eb45 · 4b7eb45
1 parent 4f171f8
commit 4b7eb45
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/controller/attendance.js b/controller/attendance.js
@@ -5,6 +5,9 @@ import {
   getAttendances,
 } from "#services/attendance";
 import { logger } from "#util";
+import { isEntityIdValid } from "#middleware/entityIdValidation";
+import Student from "#models/attendance";
+import Course from "#models/course";
 
 async function addAttendance(req, res) {
   const {
@@ -15,8 +18,15 @@ async function addAttendance(req, res) {
     cumulativeAttended,
     cumulativeOccured,
   } = req.body;
+  const isStudentValid = await isEntityIdValid(student, Student);
+  const isCourseValid = await isEntityIdValid(course, Course);
   try {
     // eslint-disable-next-line max-len
+    if (!isStudentValid || !isCourseValid) {
+      res.status(400).json({
+        error: "Invalid Id",
+      });
+    }
     const attendance = await addNewAttendance(
       student,
       course,