Revert "remove some lodash" to fix regressions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 58b441f. These changes are causing unintended visual changes, and we're not 100% sure why.
tbo47
approved these changes
Sep 30, 2024
|
I double checked all the changes from last 7.0.10 and everything looks fine. Can I release a 7.0.11? Or do you need more time for testing? @aloisklink This can be the release note:
Replacing |
Sounds good to me! I've already tested it with mermaid-js/mermaid and I didn't spot any issues! And considering the changes are so small now, I doubt there would be any issues for anybody else either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 58b441f from PR #34.
I did a
git bisecton #34, and I found that this commit was causing unintended visual changes (see #40 (comment)), and we're not 100% sure why.Unfortunately, since that commit is so large, it's hard to tell exactly which change causes the regression, so for now, we'll just revert the entire commit. Later, we can try adding it back again, piece-by-piece (ideally with a unit test!).
Closes #41 (alternate PR that fixes the same issue).