-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - copy not working on firefox #64
Conversation
Thanks @RishavT ! |
@RishavT there is a seeder script in the project that will just add enough data (few users, specifically) for you to be able to login and try out things. its here - https://github.com/tattle-made/kosh-v2/blob/main/src/backend/core/database/seeders/20211213080231-init-user-and-datasource.js.js It uses the sequelize ORM. you can read up just this page to grok it - https://sequelize.org/docs/v6/other-topics/migrations/ I am noting down the "just enough" steps to run the script regardless. caveat : I just noticed that the seeder script has 2 |
Awesome, thanks @dennyabrain ! Will test and make this PR ready for review. And yes, I'll move the code to load the script up one level (although it ideally wouldn't load it multiple times - I messed up the if condition, I'm checking just for |
Oh right, both window and navigator are from the global scope. Missed that. |
So I've been following these steps, need some help:
Hope the steps sound about right :) |
Yes, they sound right. I will send the .env file on saturday. You wont need to do step 2 any more. Sequelize takes care of initializing the db, tables and the data.you will need to run I did have more upto date instructions somewhere. Let me send those too by saturday evening. |
@RishavT I have updated the development steps here. You should be able to setup this locally now. Let me know if you face any problem. https://github.com/tattle-made/kosh-v2/blob/main/docs/dev.md Related sidenote : I was on a different linux machine right now and was able to use the "copy to clipboard" feature on both chrome and firefox :/ I will keep you posted if I can recreate this issue on my laptop and test your PR later. |
Ah, haha! Sure no worries. I do think a failsafe might be good to have anyway provided you think it's worth the increase in code (navigator.clipboard is null for me on kosh.tattle.co.in, so I'm guessing it might be null for others too). Feel free to merge or scrap at a later time, whatever you feel is appropriate :) |
Interestingly, I can also no longer replicate this issue lol on my local. navigator.clipboard is not null anymore (even in the home page on local). But when I go to kosh.tattke.co.in, navigator.clipboard comes up as null. I'm wondering if this has been fixed by some other push which isn't live yet. |
So I can't replicate the issue - and can't even set navigator.clipboard to null. I guess I'll pause development on this for now @dennyabrain . Let me know if you or anyone faces this issue again on the live website and I can dig deeper :) |
Fixes #63 (hopefully)
I can't access the tokens page, might need some help on that front - and until then I'm finding it tough to finish the following TODOs I had in mind:
Feel free to test / modify / incorporate a version of this bugfix if giving access seems tricky at the point and this is important :)