Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump go-openssl to v1.1.1 #998

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

oleg-jukovec
Copy link
Contributor

The latest version fixes a svacer issues.

The latest version fixes a svacer issues.
@oleg-jukovec oleg-jukovec added the full-ci Enables full ci tests label Nov 6, 2024
The 22.04 has OpenSSL 3 required for build.
Copy link
Collaborator

@dmyger dmyger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't there be a problem with 22 Ubuntu like there used to be?

@oleg-jukovec
Copy link
Contributor Author

Won't there be a problem with 22 Ubuntu like there used to be?

I think we can wait for problems to solve it. tt-ee is testing and building under ubuntu-22.04 and all is fine.

Copy link
Contributor

@DerekBum DerekBum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this file? Is it used in those workflows? Don't we need to update Ubuntu version here as well?

tt/ci/Dockerfile

Lines 1 to 6 in bb93392

# Docker file used in workflows:
# full-ci-ce-linux-arm64, create-packages-linux-arm64, tests-ce-linux-arm64
FROM ubuntu:20.04
ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=Etc/UTC

@oleg-jukovec
Copy link
Contributor Author

oleg-jukovec commented Nov 7, 2024

What about this file? Is it used in those workflows? Don't we need to update Ubuntu version here as well?

tt/ci/Dockerfile

Lines 1 to 6 in bb93392

# Docker file used in workflows:
# full-ci-ce-linux-arm64, create-packages-linux-arm64, tests-ce-linux-arm64
FROM ubuntu:20.04
ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=Etc/UTC

tt/ci/Dockerfile

Lines 63 to 69 in bb93392

RUN wget -P /tmp/ https://github.com/openssl/openssl/releases/download/openssl-3.0.8/openssl-3.0.8.tar.gz \
&& tar -xvf /tmp/openssl-3.0.8.tar.gz -C /tmp/ \
&& cd /tmp/openssl-3.0.8 \
&& ./Configure --prefix=/opt/openssl no-shared \
&& make -j \
&& make install \
&& rm -rf /tmp/*

It installs OpenSSL 3.0.8 directly, so it should work fine. Let's test it with merge.

@oleg-jukovec oleg-jukovec merged commit 4aa5f72 into master Nov 7, 2024
22 of 24 checks passed
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/bump-go-openssl branch November 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants