Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursion in the document loader. (#127) #1

Merged
merged 1 commit into from
Aug 2, 2022

Commits on Jul 18, 2022

  1. Avoid recursion in the document loader. (yaml#127)

    The document loading API (yaml_parser_load) was susseptable to a
    stack overflow issue when given input data which opened many
    mappings and/or sequences without closing them.
    
    This was due to the use of recurion in the implementation.
    
    With this change, we avoid recursion, and maintain our own loader
    context stack on the heap.
    
    The loader context contains a stack of document node indexes.
    Each time a sequence or mapping start event is encountered,
    the node index corrasponding to the event is pushed to the
    stack.  Each time a sequence or mapping end event is encountered,
    the corrasponding node's index is popped from the stack.
    
    The yaml_parser_load_nodes() function sits on the event stream,
    issuing events to the appropriate handlers by type.
    
    When an event handler function constructs a node, it needs to
    connect the new node to its parent (unless it's the root node).
    This is where the loader context stack is used to find the
    parent node.  The way that the new node is added to the tree
    depends on whether the parent node is a mapping (with a
    yaml_node_pair_t to fill), or a sequence (with a yaml_node_item_t).
    
    Fixes: yaml#107
    tlsa authored and ligurio committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1854848 View commit details
    Browse the repository at this point in the history