Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] update 'glob' #612

Closed
wants to merge 1 commit into from

Conversation

lloydjatkinson
Copy link

This PR upgrades the glob dependency. All tests pass with 8.x.x, and fail on any newer versions.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem Transitive: environment +7 138 kB isaacs

View full report↗︎

@bunglegrind
Copy link

#611 (comment)

@ljharb
Copy link
Collaborator

ljharb commented Sep 12, 2024

Duplicate of #611; and as you can see, tests do not pass.

@ljharb ljharb closed this Sep 12, 2024
@lloydjatkinson
Copy link
Author

OK, will migrate to vitest.

@lloydjatkinson
Copy link
Author

lloydjatkinson commented Sep 12, 2024

"glob": "^7.2.3", (the current version without this PR)

# npm run test

  391 passing (26s)
  5 pending
"glob": "^8.1.0",

# npm run test

  391 passing (26s)
  5 pending
"glob": "^9.3.5",

# npm run test

  385 passing (26s)
  5 pending
  6 failing

As you can see, tests do pass on version 8.

@ljharb
Copy link
Collaborator

ljharb commented Sep 12, 2024

@lloydjatkinson not on every version of node that tape supports.

@lloydjatkinson
Copy link
Author

Are any of those old node versions not EOL?

@ljharb
Copy link
Collaborator

ljharb commented Sep 12, 2024

EOL status is irrelevant; dropping support for any node version is a breaking change, and eliminating a transitive deprecation warning is barely enough justification for a patch release, let alone a major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants