Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): Hide bitcoind stopper #261

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Jun 28, 2024

  1. hide the bitcoind stopper inside the carrier

    this avoids having exiplict handling of the bitcoind stopper and it being all over the place
    when the carrier (by the end of the test) the stopper will get dropped as well which will cause the mock server to shutdown
    mariocynicys committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a15d8f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a0a118 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c42b29c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. make stopper non-optional in tests

    In some tests the carrier didn't need a stopper since it was already in the test scope so it would drop at the end of the test and do usual cleanup.
    This commit unifies stuff and still moves the stopper inside the carrier so that all the tests look alike (not having ones with Some(stopper) and ones with None).
    mariocynicys committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ff8a3ad View commit details
    Browse the repository at this point in the history