-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sqlx
inplace of rusqlite
#242
Open
mariocynicys
wants to merge
15
commits into
talaia-labs:master
Choose a base branch
from
mariocynicys:general-sql-engines-with-mem-opts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use sqlx
inplace of rusqlite
#242
mariocynicys
wants to merge
15
commits into
talaia-labs:master
from
mariocynicys:general-sql-engines-with-mem-opts
Commits on Sep 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e37782d - Browse repository at this point
Copy the full SHA e37782dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bbe5fa - Browse repository at this point
Copy the full SHA 8bbe5faView commit details -
This is temporary to avoid a dependency conflict that arises in `libsqlite3-sys`
Configuration menu - View commit details
-
Copy full SHA for 60e3eb7 - Browse repository at this point
Copy the full SHA 60e3eb7View commit details -
Implementing and using the sqlx drived DBM
The two DBMs are now in use, this is an intermediary commit and `dbm.rs` should be deleted and replaced with `dbm_new.rs`, and the tower components should be adjusted accordingly (drop the mutex around the dbm since the pool handles it by itself & await on dbm methods since they are now async)
Configuration menu - View commit details
-
Copy full SHA for b5ba42b - Browse repository at this point
Copy the full SHA b5ba42bView commit details
Commits on Sep 20, 2023
-
Moving the tower components to async
Some mutexed needed their lifetimes be shortened due to the fact that an std mutex guard can't live across await point. one specific mutex on GateKeeper::registered_users was more fitting to be a tokio mutex instead due to the nature of how it is uses beside the database usage (std mutex is generally better/has less overhead than a tokio mutex). tests still need to be patched for async
Configuration menu - View commit details
-
Copy full SHA for 9c9f7fd - Browse repository at this point
Copy the full SHA 9c9f7fdView commit details -
Adjusted the tests (basically adding .awaits)
Postgres tests are still not working because with each test we need to spawn a brand new database (best done inside a docker container) from within the tests
Configuration menu - View commit details
-
Copy full SHA for 38abec0 - Browse repository at this point
Copy the full SHA 38abec0View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4bd2051 - Browse repository at this point
Copy the full SHA 4bd2051View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba321f4 - Browse repository at this point
Copy the full SHA ba321f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5519d0 - Browse repository at this point
Copy the full SHA e5519d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 233b604 - Browse repository at this point
Copy the full SHA 233b604View commit details -
this still needs an external test db running on the background. one can easily be spawned with docker
Configuration menu - View commit details
-
Copy full SHA for 178729f - Browse repository at this point
Copy the full SHA 178729fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d42d4bc - Browse repository at this point
Copy the full SHA d42d4bcView commit details -
remove DB logic from teos-common
remove rusqlite dependency from teos-common
Configuration menu - View commit details
-
Copy full SHA for 3aaa7c9 - Browse repository at this point
Copy the full SHA 3aaa7c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d4e6ea - Browse repository at this point
Copy the full SHA 0d4e6eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 782ed39 - Browse repository at this point
Copy the full SHA 782ed39View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.