-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive the project #257
Merged
Merged
Revive the project #257
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f65a18f
High level changes:
cstamas af02dfa
Ignore failing test for now
cstamas dce586d
Merge remote-tracking branch 'origin/master' into review-the-project
cstamas 8a57525
Aling p-u
cstamas 81f25ea
Update parent to 51
cstamas 746ef51
Merge remote-tracking branch 'origin/master' into review-the-project
cstamas 507920d
Sort out p-u scopes
cstamas d89f08c
Updated requirements in readme
lefou 37eb124
Merge remote-tracking branch 'origin/master' into review-the-project
cstamas 644ff8a
Go back to altest lifecycle that can run on Java8
cstamas c564c0f
Apply proposal, make Java 8 part of CI as well
cstamas 85ad6af
Shared GH workflow does not support java 8
cstamas 2c8849d
Merge remote-tracking branch 'origin/master' into review-the-project
cstamas e2f567a
Fix GH
cstamas 134bbdd
Update some stale deps
cstamas 8243ec6
Up Maven version to 3.9.5
cstamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,11 @@ | ||
name: ci | ||
name: Verify | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
|
||
jobs: | ||
setup: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Stop old builds | ||
if: github.ref != 'refs/heads/master' | ||
uses: styfle/[email protected] | ||
with: | ||
access_token: ${{ github.token }} | ||
|
||
build: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
java-version: [8,11] | ||
needs: setup | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-java@v1 | ||
with: | ||
java-version: ${{ matrix.java-version }} | ||
- name: Build & Test | ||
run: ./mvnw -B verify | ||
name: Verify | ||
uses: takari/takari-gh-actions/.github/workflows/ci.yml@v1 | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,16 +7,18 @@ | |
*/ | ||
package org.sonatype.maven.polyglot.atom; | ||
|
||
import org.codehaus.plexus.component.annotations.Component; | ||
import org.sonatype.maven.polyglot.mapping.Mapping; | ||
import javax.inject.Named; | ||
import javax.inject.Singleton; | ||
|
||
import org.sonatype.maven.polyglot.mapping.MappingSupport; | ||
|
||
/** | ||
* Atom compact grammar model mapping. | ||
* | ||
* @author [email protected] (Dhanji R. Prasanna) | ||
*/ | ||
@Component(role = Mapping.class, hint = "atom") | ||
@Singleton | ||
@Named( "atom" ) | ||
public class AtomMapping extends MappingSupport { | ||
public AtomMapping() { | ||
super("atom"); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,15 +7,16 @@ | |
*/ | ||
package org.sonatype.maven.polyglot.atom; | ||
|
||
import javax.inject.Named; | ||
import javax.inject.Singleton; | ||
|
||
import java.io.IOException; | ||
import java.io.Reader; | ||
import java.util.Map; | ||
|
||
import org.apache.maven.model.Model; | ||
import org.apache.maven.model.building.ModelProcessor; | ||
import org.apache.maven.model.building.ModelSource; | ||
import org.apache.maven.model.io.ModelReader; | ||
import org.codehaus.plexus.component.annotations.Component; | ||
import org.codehaus.plexus.util.IOUtil; | ||
import org.sonatype.maven.polyglot.atom.parsing.AtomParser; | ||
import org.sonatype.maven.polyglot.atom.parsing.Project; | ||
|
@@ -27,7 +28,8 @@ | |
* | ||
* @author [email protected] (Dhanji R. Prasanna) | ||
*/ | ||
@Component(role = ModelReader.class,hint="atom") | ||
@Singleton | ||
@Named( "atom" ) | ||
public class AtomModelReader extends ModelReaderSupport { | ||
|
||
public Model read(final Reader input, final Map<String, ?> options) throws IOException { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 7 additions & 5 deletions
12
polyglot-common/src/main/java/org/sonatype/maven/polyglot/TeslaProjectBuilder.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost identically to what we had before, except the newer version of the
action/cehckout
action. As we want to keep Java 8 coverage, I suggest to either drop that change or pass a changed java-version-matrix to that re-used job.Maybe the following works. If not, the
takari-gh-actions
might need to be changed to support changing that value.See also this docuemntation: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-a-matrix-strategy-with-a-reusable-workflow