Make use of new bemenu password indicator option #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmeum
force-pushed
the
pr/password-indicator
branch
from
815f20b
to
f471607
Compare
This option was added in bemenu 0.6.17, when enable it displays asterisks instead of hiding the input text entirely. This is also what pinentry-gtk does and I think it's much more user friendly.
|
Thanks! I'd like to have a cli option for this that mimics the one from |
nmeum
force-pushed
the
pr/password-indicator
branch
from
f471607
to
375ed28
Compare
|
Hi, thanks for the quick reply. Updated accordingly, does warrant some further testing. I also created Cloudef/bemenu#388 in the hopes that we can reduce code duplication with upstream regarding option handling. |
t-8ch
reviewed
Feb 25, 2024
| else if (!strcmp(password, "none")) | ||
| bm_menu_set_password(menu, BM_PASSWORD_NONE); | ||
| else if (!strcmp(password, "indicator")) | ||
| bm_menu_set_password(menu, BM_PASSWORD_INDICATOR); |
There was a problem hiding this comment.
Please also a fallback to BM_PASSWORD_HIDE,
Other than that it looks great.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, right. Good catch! Should be fixed now.
nmeum
force-pushed
the
pr/password-indicator
branch
from
375ed28
to
d35e7fb
Compare
|
@t-8ch Would it be possible to cut a new release that includes this feature? |
Thanks for the reminder. Done in v0.13.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added in bemenu 0.6.17, when enable it displays asterisks instead of hiding the input text entirely. This is also what pinentry-gtk does and I think it's much more user friendly as it clearly indicates that input has been received by bemenu-pinentry.