Support Incoming Properties #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have completed the implementation, please check the example. |
|
I'll check this in weekend, thanks! |
syumai
reviewed
Jan 21, 2024
syumai
reviewed
Jan 21, 2024
_examples/incoming/go.mod
Outdated
| @@ -0,0 +1,7 @@ | |||
| module github.com/syumai/workers/_examples/hello | |||
There was a problem hiding this comment.
Suggested change
| module github.com/syumai/workers/_examples/hello | |
| module github.com/syumai/workers/_examples/incoming |
syumai
reviewed
Jan 21, 2024
cloudflare/incoming/property.go
Outdated
| @@ -0,0 +1,159 @@ | |||
| package incoming | |||
There was a problem hiding this comment.
incoming seems a part of fetch feature.
Can we merge these package?
aki-0421
force-pushed
the
incoming-properties
branch
from
7bcafbb
to
3377f3c
Compare
aki-0421
force-pushed
the
incoming-properties
branch
from
3377f3c
to
83be8bc
Compare
|
I have made some |
syumai
reviewed
Jan 24, 2024
| return err | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func init() { | ||
| runSchedulerCallback := js.FuncOf(func(_ js.Value, args []js.Value) any { | ||
| if len(args) != 2 { | ||
| if len(args) != 1 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Incoming Properties with this change. But WIP
Motivation
https://developers.cloudflare.com/workers/runtime-apis/request/#incomingrequestcfproperties