Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Adds support for Read Reports (#84) #85

Merged
merged 10 commits into from
Nov 5, 2013
Merged

Conversation

efullea
Copy link
Member

@efullea efullea commented Oct 23, 2013

No description provided.

@airpingu
Copy link

I'll take the review by this week. Thank you!

@zolkis
Copy link
Contributor

zolkis commented Oct 29, 2013

Looks OK.

efullea pushed a commit that referenced this pull request Nov 5, 2013
Adds support for Read Reports (#84)
@efullea efullea merged commit 60f83bb into sysapps:gh-pages Nov 5, 2013
<li>in case the message has been read, with each of the items in the
<code>readTimestamps</code> attribute set to the read time of
the MMS message by the corresponding recipient, i.e. that in the
same position of the <code>recipients</code> array.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering one thing which might not related to this bug. So, the number of elements in the deliveryInfo array will correspond to the number of recipients array? If yes, why do we still need |MmsDeliveryInfo.recipient|? I originally thought that's why you want to add |recipient| for indexing and de-duplicating same duplicated recipients.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of elements in the deliveryInfo array will correspond to the amount of elements in the to, cc and bcc arrays unless there are duplicates. There are two reasons to keep MmsDeliveryInfo.recipient :

  • Not having to deal with complex mapping between the recipients in to, cc and bcc and the elements in the deliveryInfo[] array
  • de-duplicating recipients

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Mozilla will try to align the spec to this. Even if we don't have cc/bcc for now, we'd still have the duplication issue in the |receivers|.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants