fix(#258): !improve status condition to reflect multiple pipelines #259
+74
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richcooper95
force-pushed
the
fix/258/multiple-pipelines-condition
branch
from
328b409
to
af02c41
Compare
This commit: - changes the `PipelineCompleted` condition type to `ConfigureWorkflowCompleted` - updates the condition message to reflect the completion of multiple pipelines - only sets the condition to `True` when the last pipeline in a Configure workflow has completed successfully Previously, we set the `PipelineCompleted` condition to `True` at the end of every successful Pipeline in a Configure workflow. This meant there was a window in which the condition could be set to `True` before all Pipelines had completed (before the next Pipeline was triggered and the condition was reset to `False`). This commit includes a change to `update-status` to only set the `ConfigureWorkflowCompleted` condition to `True` when the last Pipeline in the Configure workflow has completed successfully. BREAKING CHANGE: Any automation relying on the `PipelineCompleted` condition type will need to be updated to watch for the new `ConfigureWorkflowCompleted` condition type instead. This is semantically interchangeable, but reflects the completion of multiple pipelines in a Configure workflow. Co-authored-by: Jake Klein <[email protected]>
richcooper95
force-pushed
the
fix/258/multiple-pipelines-condition
branch
from
af02c41
to
391ff6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
PipelineCompletedcondition type toConfigureWorkflowCompletedTruewhen the last pipeline in a Configure workflow has completed successfullyPreviously, we set the
PipelineCompletedcondition toTrueat the end of every successful Pipeline in a Configure workflow. This meant there was a window in which the condition could be set toTruebefore all Pipelines had completed (before the next Pipeline was triggered and the condition was reset toFalse).This commit includes a change to
update-statusto only set theConfigureWorkflowCompletedcondition toTruewhen the last Pipeline in the Configure workflow has completed successfully.BREAKING CHANGE: Any automation relying on the
PipelineCompletedcondition type will need to be updated to watch for the newConfigureWorkflowCompletedcondition type instead. This is semantically interchangeable, but reflects the completion of multiple pipelines in a Configure workflow.