Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller runtime to 0.17 #124

Merged
merged 1 commit into from
May 14, 2024
Merged

Bump controller runtime to 0.17 #124

merged 1 commit into from
May 14, 2024

Conversation

ChunyiLyu
Copy link
Member

There were some changes needed for our unit test continue to work:

  1. set GVK in Work test explicitly, this is because controller runtime no long set TypeMeta for objects unless it's unstructured, see: ⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633
  2. Some changes in error messages
  3. Regenerate manager fakes

- Set GVK in work test explicitly
- Regenerate manager fakes
- Update expected event message
@ChunyiLyu ChunyiLyu merged commit 023d8e2 into main May 14, 2024
8 checks passed
@ChunyiLyu ChunyiLyu deleted the bump-controller-runtime branch May 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants