feat: add better typing with generics #1431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbadstuebner
changed the title
jonasbadstuebner
changed the title
|
I also offer to implement the types in more places, these 3 packages are only the ones I use, that's why they I chose to do it there. |
|
Why is this merge request open for so long? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Please have a look at this PR now.
I removed all the special stuff I did (I hope) - I will create new PRs for that seperately.
This PRs goal is to make use of the generics feature of Flutter to get rid of all the "dynamic" stuff that did lead to a lot of issues on my side and a lot of trouble implementing for example the calendar correctly.
With this PR merged, you can specify the type of custom Appointment like
It is a breaking change. But worth it in my opinion, because in every implementation there could be a casting error hiding right now. With using types, this is way less likely.
Also all the conversion steps from
dynamicto any DateTime value are gone now.I am happy to help and answer any question regarding this PR.