Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New documentation #223

Merged
merged 41 commits into from
Mar 2, 2016
Merged

New documentation #223

merged 41 commits into from
Mar 2, 2016

Conversation

bobvandevijver
Copy link
Member

This is a work-in-progress and aims to create a full documentation of this bundle.

Checklist:

List of things I won't do:

The documentation for now is placed in a new directory, which will replace the old documentation directory after merge.

Note that #128 was the previous PR for the documentation, this is a reboot which already contains the needed work from that.

Any help is appreciated, just let me know what you are working on!

@ioleo
Copy link
Member

ioleo commented Jan 4, 2016

@bobvandevijver what are you missing in #221 to document?

@bobvandevijver
Copy link
Member Author

Well, we changed behavior of the credentials part, so there should at least be an upgrade note about it. Furthermore, the changes for JMS are not yet incorporated in this doc. Finally I would like to see a complete example of how the credentials work and what is possible with them.

@ioleo
Copy link
Member

ioleo commented Jan 4, 2016

@sescandell could you fill in the gaps?

@sescandell
Copy link
Member

Hi,

I don't get it. Is https://github.com/symfony2admingenerator/GeneratorBundle/blob/master/Resources/doc/security/credentials.md not enough (I mean, as a first step)?

@bobvandevijver
Copy link
Member Author

@sescandell I missed that you updated the doc in the PR, I'm sorry!

@sescandell sescandell mentioned this pull request Feb 1, 2016
@sescandell
Copy link
Member

👍

@bobvandevijver
Copy link
Member Author

@sescandell/@loostro: Can one of you check the documentation of the Options class? As I do not use it currently I'm not sure if it's correct, but I think it should be okay 👍

@ioleo
Copy link
Member

ioleo commented Feb 5, 2016

@bobvandevijver I'd just like to add that Form specific options take precedence over Options class.

Eg. if the system tries to render edit form with category field:

  • it will first check if EditType class has getCategoryOptions method. If it exists, it will be used.
  • then it will check if Options class has getCategoryOptions method. If it exists, it will be used.

Note that if both classes have getCategoryOptions method, then the latter (Options) will get (as an argument) fieldOptions already modified by previous (EditType) method.

See implementation here

@bobvandevijver
Copy link
Member Author

Okay, I made quite some progress for tonight. I will try to create the new/edit/list/show builder documentation this week.

In the meantime, can your guys check the doc so far? ( @sescandell @loostro @tobias-93 ) I do not plan on making the embed/nested list documentation: I do not use it so I have no idea how to document it. I also do not know what column groups are.

I've moved those checkboxes to the bottom of the list, I hope you guys can check them. Otherwise, I would propose that as soon as I finish my list, this PR is merged such that the docs can be used easily by everyone. The embedded/nested/column group will than be added later.

@bobvandevijver bobvandevijver changed the title [WIP] New documentation New documentation Mar 1, 2016
@bobvandevijver
Copy link
Member Author

This PR is now ready to merge! @sescandell & @loostro, please provide me with some feedback, otherwise I'll merge it next week :)

*/
private $version;

public function getVersion(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS fix:

public function getVersion()
{

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I do not use that style (because of the extra line), but I will fix it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of PSR-2 which is used by symfony2 core

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but I like to be different :p. Anyway, it's fixed 👍

@ioleo
Copy link
Member

ioleo commented Mar 1, 2016

@bobvandevijver great job 👍 !

@sescandell
Copy link
Member

Awesome work @bobvandevijver 👍

bobvandevijver added a commit that referenced this pull request Mar 2, 2016
@bobvandevijver bobvandevijver merged commit 2679e7d into master Mar 2, 2016
@bobvandevijver
Copy link
Member Author

Merged 🎉

@bobvandevijver bobvandevijver deleted the new-doc branch March 6, 2016 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix doc
4 participants