Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LiveComponent] Fix PHP8.4 errors + deprecations #2079

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

smnandre
Copy link
Member

First patch of fixes (thanks to the PHP 8.4 tesst)

@smnandre
Copy link
Member Author

🆘 @kbond 😅

@kbond
Copy link
Member

kbond commented Aug 20, 2024

Oi! We don't run foundry's CI on PHP 8.4 yet - hopefully these are issues there. I've created an issue to track zenstruck/foundry#687

@smnandre
Copy link
Member Author

@kbond sorry i was unclear 😓

I started on PHP 8.4 but there were deprecations on PHP 8.3..

So i decided to un-lock the Foundry version.

This PR failures come from me upgrading Foundry, but are on the current PHP version... and i'm a bit blocked here :/

i must have messed something in the upgrade

@nikophil
Copy link

Hi @smnandre

I've opened a PR based on yours which fixes the CI

smnandre#2

I'm not really sure where the problem was coming from, though 😅

@smnandre
Copy link
Member Author

Oh this is no nice, thank you !! 😃

@smnandre
Copy link
Member Author

I'll merge it in mine and we'll see from there.. as the CI does not run on my fork :)

@smnandre
Copy link
Member Author

Looks good.... (thank you very much!)) ..
Except Icon now stuck in something that looks to me related to ConsoleTest / Foundry !

I'm sorry 😅

@smnandre
Copy link
Member Author

Update: not at all, 100% my fault ....

Runtime:       PHP 8.3.10
Configuration: /Users/simonandre/Sites/symfony/ux/src/Icons/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing 
....."""
 ------------ ------- --------- ------------ --------------------- \n
  Icon set     Icons   License   Prefix       Example              \n
 ------------ ------- --------- ------------ --------------------- \n
  Lucide        1524   ISC       lucide       lucide:check-circle  \n
  Lucide Lab     373   ISC       lucide-lab   lucide-lab:venn      \n
 ------------ ------- --------- ------------ --------------------- \n
\n

Lucide is just no the only result for the query "lucide" ... deepest apologies 💐

@kbond
Copy link
Member

kbond commented Aug 24, 2024

Oi, yeah that's a brittle test

@smnandre
Copy link
Member Author

Yeah perfect! Thank you @kbond & @nikophil for the help :)

@smnandre smnandre added the Icons label Aug 24, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 25, 2024
@smnandre smnandre merged commit 211ee5b into symfony:2.x Aug 25, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icons LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants