Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Map] Fix options URL #1355

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[UX Map] Fix options URL #1355

merged 1 commit into from
Nov 12, 2024

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Nov 12, 2024

Q A
License MIT
Doc issue/PR -

This PR fix options URLs in manifest.json for both Leaflet and Google Map

Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1355/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1355/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/ux-google-map:^2.19' 'symfony/ux-leaflet-map:^2.19'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@symfony-recipes-bot symfony-recipes-bot merged commit 21ffab2 into symfony:main Nov 12, 2024
1 of 2 checks passed
@ker0x ker0x deleted the patch-1 branch November 13, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants