Fix compatibility with PHPUnit 11 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Nov 6, 2024
Tests/DependencyInjection/Compiler/AddSwiftMailerTransportPassTest.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
improvement/phpunit-11-compat
branch
from
af88e9d
to
1e2cbbc
Compare
derrabus
added a commit
that referenced
this pull request
Nov 6, 2024
This PR was merged into the 3.x-dev branch. Discussion ---------- do not mock Symfony DI component classes see #493 (comment) Commits ------- 5142756 do not mock Symfony DI component classes
derrabus
force-pushed
the
improvement/phpunit-11-compat
branch
from
1e2cbbc
to
7c93761
Compare
xabbuh
approved these changes
Nov 6, 2024
|
Thank you Alexander. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of compatibility issues with PHPUnit 11:
setMethods()method anymore.Test.Note: The tests are still run with PHPUnit 8.5 and 9.6 though. The PR merely enables us to use PHPUnit 11 in the future.