Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I now have a complete interface to the routines in
<cwrapper.h>
. To ease the task I have leveragedfypp
to do part of the work. I've also used fypp for conditional compilation, meaning that commands such as:are needed. This also means the flags from the C++ SymEngine build need to be somehow propagated to the Fortran version.
I still need to create the unit tests to make sure that my type translations are correct:
typedef basic_struct basic[1];
which is used to force reference semantics@certik Do you think unit tests are needed on the level of the C interface (where we work explicitly with the handles to
type(c_ptr)
) or would it suffice to have tests of the higher level interface (still to be developed)?My current plan was to adapt the tests found in
test_cwrapper.c
of SymEngine. I won't be able to make progress that fast, but thought I will just create a PR if anyone else would like to contribute to my fork.