Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restaurants map #17

Merged
merged 17 commits into from
Oct 29, 2017
Merged

Restaurants map #17

merged 17 commits into from
Oct 29, 2017

Conversation

josefdolezal
Copy link
Contributor

@josefdolezal josefdolezal commented Oct 27, 2017

Hey @syky27! As discussed in #16, I started with implementation of static location provider for restaurants. Current state is visible on the attached image.

group 2x

PR roadmap:

  • Create static location resolver for restaurants
  • Create simple shared data storage
  • Add possibility to switch between list and map views
  • Add caption for pins on map
  • Open restaurant menu from map
  • Open Google Maps/Apple Maps with POI from restaurant menu
  • Position map correctly when the app starts
  • Add changelog entry

@josefdolezal
Copy link
Contributor Author

Hey @syky27, all features from this PR are done. Would you please update the CHANGELOG? I am not sure what version I should use.

New features are:

  • Map view of restaurants
  • Integration with 3rd party apps (Apple Maps, Google Maps and Yelp)

I you will bump the version, also the project file should be updated.

@syky27 syky27 changed the title WIP: Restaurants map Restaurants map Oct 29, 2017
@syky27
Copy link
Owner

syky27 commented Oct 29, 2017

Project file gets updated automatically when Changelog changes on CI...

@syky27
Copy link
Owner

syky27 commented Oct 29, 2017

Fixes #16

@syky27 syky27 merged commit 01af96b into syky27:dev Oct 29, 2017
@josefdolezal josefdolezal deleted the jdo/restaurants-map branch October 29, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants