-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate maps view as an alternative to restaurants list #16
Comments
I totally agree |
But #4 is more pressing matter right now... |
I believe that it needs to be mentioned inside the app to comply with those Licenses....
--
Tomas Sykora
… On 26 Oct 2017, at 23:26, Josef Doležal ***@***.***> wrote:
Yeah, I was also thinking about it. Since we removed most of the dependencies in last PR, I think it will be enough to just mention and link Alamofire, Fabric and Crashlytics from README. So it mostly depends on #13 <#13>.
cc @hroncok <https://github.com/hroncok>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACpLWihj8OUeW2CauQ0e6UChu7VBbHYGks5swPkAgaJpZM4QIO1d>.
|
Your are slipping from the topic of this issue ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @syky27! I would like to open discussion about map of restaurants from obedar API.
Context
I am using LunchGuy few times a week and usually, I check only one or two restaurants, since I don't know where the rest of them is located. It would be nice to have:
Proposal
Create new
LocationProvider
protocol which will returnCLLocationCoordinate2D
for given restaurant. I saw tomaskadlec/lunch_guy#54 and tomaskadlec/lunch_guy#58 and I know that it's not currently implemented at backend. However, the list of restaurants has now less than twenty items, so we can create static provider. It would simply match restaurant by its name and return coordinates from hardcoded set. Once the backend implements this feature, we can just swap implementation ofLocationProvider
.The UI would contain:
What do you think?
The text was updated successfully, but these errors were encountered: