add .gitlab-ci.yml #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 34 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v34...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps google.golang.org/protobuf from 1.31.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Henrique Oliveira <[email protected]> Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]> Signed-off-by: Henrique Oliveira <[email protected]>
feat(ec2/securitygroup)!: Make region a required field
Signed-off-by: Logan Bowe <[email protected]>
fix(efs): Add poll-interval to EFS mount target
…t-ignore-aws-system-tags fix(s3 bucket): Ignore AWS system tags
…pendabot/go_modules/google.golang.org/protobuf-1.33.0 chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0
…pendabot/github_actions/dot-github/workflows/tj-actions/changed-files-41 chore(deps): bump tj-actions/changed-files from 34 to 41 in /.github/workflows
Signed-off-by: Kirill Sushkov (teeverr) <[email protected]>
…cket-ignore-aws-system-tags fix(s3 bucket): hotfix for ignoring AWS system tags
Resource tags are used to ensure that only IAM roles with the right access can modify the resources. This ensures that the security groups will have the right tags from creation time. Without this change, IAM policy based on tags may fail to run subsequent steps of security group creation. Signed-off-by: justin.miron <[email protected]>
This ensures that when tags change, the EC2 instance reconciles the update. Previously the ec2 instance controller supported updating tags via `CreateTags` but did not perform reconciliation when tags changed as it was not included in the check for if the EC2 instance was up to date. However, the way `Update` is currently implemented had the implicit assumption that the EC2 instance must be stopped for all updates, which is true for all the ModifyInstanceAttribute calls, however, tags can be applied at runtime. This changes the logic of the controller to (1) include the instance attributes in the instance observations, (2) only attempt to modify instance attributes if the observation does not match the spec. Signed-off-by: justin.miron <[email protected]>
The EC2 instance controller synchronously makes several DescribeInstanceAttribut calls to the EC2 API and does not use the results. This slows down the reconcile time for a single observation. This removes the API calls for attributes that are returned in `RunInstances`. Signed-off-by: justin.miron <[email protected]>
…e-attributes ec2: include attributes in instance observation, fix reconciling tags
…tion-time-sg ec2: Create security group with tags in the spec
Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
…ce-updateloop-restorefrom fix(database): ignore restoreFrom in isUpToDate
…controller-api-calls Reduce ec2 instance controller API calls for an observation
…torageThroughput Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
For records that have MultiValueAnswer and SetIdentifier fields. Signed-off-by: Max Melentyev <[email protected]>
Otherwise AWS returns ALL routes with name > requested one. Signed-off-by: Max Melentyev <[email protected]>
…e-iops-storagethroughput-isuptodate-fix fix(dbinstance): in isUpToDate consider 0 and nil to be equal for iops/storageThroughput
…hanges-detection Fix changes detection for route53.ResourceRecordSet
…ce readiness Signed-off-by: David Lopes <[email protected]>
…pi-call Call route53.ListResourceRecordSets with MaxItems = 1
…-with-desired-count fix: take into consideration the DesiredCount/RunningCount for resource readiness
Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
…nce-storagethroughput-fix-dbinstance-iops-storagethroughput feat(rdsinstance): add storageThroughput
Replace imported types with plane strings. Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
added 14 commits
June 3, 2024 21:50
added 13 commits
June 6, 2024 18:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested