-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/b val uncertainty #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! We can ask others if more clarification on b vs beta values is needed, but I think it's fine.
weights: Optional[list] = None, | ||
gutenberg: bool = False, | ||
error: bool = False | ||
) -> (float, float): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schmidni the output is either just a float or a tuple(float, float), depending on the parameter gutemberg. Is this hinted correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Union[float, Tuple[float, float]]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Union[float, Tuple[float, float]]?
correct.
@adzubay I included the uncertainty in the estimate_beta_tinti function, can you check if it works? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncertainty addition in estimate_beta functions worked well for me!
No description provided.