Feature/beta2b and warnings #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aronsho
commented
Jun 5, 2024
•
aronsho
commented
- b-to-beta function included (and beta_to_b)
- Included the warning option (if the global warning option is set to False, no warnings are shown)
- Simplified the reverse_dot_size function
…estimate_b and changed testing
Closed
aronsho
requested review from
martahan and
RitzVanille
and removed request for
martahan
aronsho
commented
Jun 5, 2024
| * (1 - (method == "utsu")) | ||
| * (1 - (method == "tinti")) | ||
| * (1 - (method == "laplace")) | ||
| return_n * (1 - (method == "utsu")) * (1 - (method == "tinti")) |
There was a problem hiding this comment.
change this, only positive is possible
aronsho
commented
Jun 5, 2024
| with open("seismostats/analysis/tests/data/test_shi_bolt_confidence.p", | ||
| "rb") as f: | ||
| with open( | ||
| "seismostats/analysis/tests/data/test_shi_bolt_confidence.p", "rb" |
There was a problem hiding this comment.
add issue for weir d pickle things
|
did 4eyes review with vanille |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.