Use late static binding to show the correct class as parser with the …

…BaseJavascriptParser
swisnl · Feb 5, 2018 · 09f22ec · 09f22ec
1 parent 681bfde
commit 09f22ec
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/src/Parsers/Behat.php b/src/Parsers/Behat.php
@@ -44,7 +44,7 @@ public function run(Repository $repository, Result\ValidationInterface $validati
                         $line->getCommit()->getAuthorName(),
                         $line->getCommit()->getAuthorEmail(),
                         $line->getCommit()->getCommitterDate()->getTimestamp(),
-                        self::class
+                        static::class
                     );
                 }
             }

diff --git a/src/Parsers/Codeception/Cept.php b/src/Parsers/Codeception/Cept.php
@@ -40,7 +40,7 @@ public function run(Repository $repository, Result\ValidationInterface $validati
                 $line->getCommit()->getAuthorName(),
                 $line->getCommit()->getAuthorEmail(),
                 $line->getCommit()->getCommitterDate()->getTimestamp(),
-                self::class
+                static::class
             );
         }
 

diff --git a/src/Parsers/Codeception/Cest.php b/src/Parsers/Codeception/Cest.php
@@ -45,7 +45,7 @@ public function run(Repository $repository, Result\ValidationInterface $validati
                         $line->getCommit()->getAuthorName(),
                         $line->getCommit()->getAuthorEmail(),
                         $line->getCommit()->getCommitterDate()->getTimestamp(),
-                        self::class
+                        static::class
                     );
                 }
             }

diff --git a/src/Parsers/JavaScript/BaseJavaScriptParser.php b/src/Parsers/JavaScript/BaseJavaScriptParser.php
@@ -40,7 +40,7 @@ public function run(Repository $repository, Result\ValidationInterface $validati
                         $line->getCommit()->getAuthorName(),
                         $line->getCommit()->getAuthorEmail(),
                         $line->getCommit()->getCommitterDate()->getTimestamp(),
-                        self::class
+                        static::class
                     );
                 }
             }

diff --git a/src/Parsers/PhpUnit.php b/src/Parsers/PhpUnit.php
@@ -39,7 +39,7 @@ public function run(Repository $repository, Result\ValidationInterface $validati
                         $line->getCommit()->getAuthorName(),
                         $line->getCommit()->getAuthorEmail(),
                         $line->getCommit()->getCommitterDate()->getTimestamp(),
-                        self::class
+                        static::class
                     );
                 }
             }

diff --git a/tests/Parsers/BaseParserTestCase.php b/tests/Parsers/BaseParserTestCase.php
@@ -22,6 +22,7 @@ protected function setUp()
      * @param ParserInterface $parser
      * @param array $expectedFiles What files do we expect as result
      * @param int $expectedCount How many tests should be counted
+     * @return Result[]
      */
     protected function runParserTest($parser, $expectedFiles, $expectedCount)
     {
@@ -33,6 +34,8 @@ protected function runParserTest($parser, $expectedFiles, $expectedCount)
         foreach ($results as $result) {
             static::assertInstanceOf(Result::class, $result);
 
+            static::assertEquals(get_class($parser), $result->getParser());
+
             if (in_array($result->getFilename(), $expectedFiles)) {
                 $count++;
             }
@@ -42,5 +45,7 @@ protected function runParserTest($parser, $expectedFiles, $expectedCount)
             $count,
             'Check if file list has ' . $expectedCount . ' results.'
         );
+
+        return $results;
     }
 }