Experimental: Remove hard CodeLLDB dependency #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to test this you need to uninstall the released version of the swift extension otherwise you can't uninstall CodeLLDB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dialog that is displayed if the CodeLLDB dependency is not available. You can install the dependency from this dialog, set it to never appear again or just ignore it. This actually works out quite nicely.
Problems occur if you have the dependency installed but disabled. It cannot recognise this. Also if you go into a devcontainer without CodeLLDB but have it installed locally you cannot install it into the devcontainer. You need the user to go do it manually. Not too much of a problem if I could recognise you were in a container.